[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 17:29:07 PST 2012


--- Comment #36 from Chris Rogers <crogers at google.com>  2012-02-17 17:29:07 PST ---
(From update of attachment 127537)
View in context: https://bugs.webkit.org/attachment.cgi?id=127537&action=review

> Source/WebCore/platform/audio/Biquad.cpp:57
> +    m_biquadState = 0;

I'm not clear how m_biquadState is allocated, since I see that we call ippsIIRFree64f_32f(m_biquadState); on line 78

Is it in the ippsIIRInit64f_BiQuad_32f() call in setNormalizedCoefficients()?  I'm not clear about that.

If this is the case, then what happens if somebody tries to use the filter with the default settings (where setNormalizedCoefficients() never is called).

Also, it looks like reset() sets m_biquadState back to 0 and we have a similar problem?

> Source/WebCore/platform/audio/Biquad.cpp:213
> +        m_biquadState = 0;

See comment above about how m_biquadState is initialized

> Source/WebCore/platform/audio/Biquad.h:113
> +#endif // USE(WEBAUDIO_IPP)

Do we even use the m_b0 (and similar) and m_x1 (and similar) member variables in the IPP case?
If not then we should wrap them in

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list