[Webkit-unassigned] [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9767





--- Comment #28 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-02-17 15:20:23 PST ---
(In reply to comment #6)
> (From update of attachment 126875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126875&action=review
> 
> > Source/WebCore/platform/graphics/BitmapImage.cpp:454
> > -    if (!skippingFrames && imageObserver()->shouldPauseAnimation(this))
> > +    if (imageObserver()->shouldPauseAnimation(this))
> 
> I'm not totally sure if this is correct, but if shouldPauseAnimation() is not checked when skipping frames, the effect is advancing one frame at a time in some common situations (like switching tabs and back). If there's a better place to make the check let me know.

I'm not an expert on this either.  I am similarly curious if this is the correct code change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.