[Webkit-unassigned] [Bug 78785] Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78785





--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-02-17 12:12:25 PST ---
(From update of attachment 127522)
View in context: https://bugs.webkit.org/attachment.cgi?id=127522&action=review

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:121
> +float RenderThemeBlackBerry::defaultFontSize = 16.0;

Could move this up with the other constants

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:180
> +    // in-page mode the same as in fullscreen mode..

I'd do either 1 or 3 periods :)

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:187
> +    return 0.0; // Turn off caret blinking.

Better use 0.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:804
> +    // paint main slider bar

Not a sentence.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:811
> +        // paint played part of bar (left of slider thumb) using selection color

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.