[Webkit-unassigned] [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9767





--- Comment #26 from Pablo Flouret <pablof at motorola.com>  2012-02-17 11:47:41 PST ---
(In reply to comment #25)
> (From update of attachment 127468 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127468&action=review
> 
> I looked over the bulk of this patch, and it all looks pretty good to me.  I'm not an expert on all of the ports, but the code for them looks reasonable.
> 
> > LayoutTests/fast/images/disallow-animated-images.html:34
> > +        }, 150); // Green frame of GIF has 100ms duration
> 
> what if this timer happens to be delayed due to some slowness on the bot?  if it ends up running after 200 msec, then won't this test potentially fail?
> 
> when you rely on timers like this in tests, it is very easy to introduce a flaky test.  is there any other way to approach this that won't be so sensitive to such issues?

There's one frame of green and five frames of red, 100ms each. Also, the idea is that the animation does not run, so if the code that disables animations works correctly, (in theory) it doesn't really matter how long you wait until you look for the result, it will always be green.
If the code doesn't work then it would have to be delayed the exact time to fall back into the green zone, so it would be potentially flaky in that case, but then again, it would also be failing.

I ran it with --repeat-each=1000 a bunch of times and didn't find any flakiness, but if you can think of a better way to test this i'm open to suggestions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.