[Webkit-unassigned] [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9767





--- Comment #25 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-02-17 11:35:21 PST ---
(From update of attachment 127468)
View in context: https://bugs.webkit.org/attachment.cgi?id=127468&action=review

I looked over the bulk of this patch, and it all looks pretty good to me.  I'm not an expert on all of the ports, but the code for them looks reasonable.

> LayoutTests/fast/images/disallow-animated-images.html:34
> +        }, 150); // Green frame of GIF has 100ms duration

what if this timer happens to be delayed due to some slowness on the bot?  if it ends up running after 200 msec, then won't this test potentially fail?

when you rely on timers like this in tests, it is very easy to introduce a flaky test.  is there any other way to approach this that won't be so sensitive to such issues?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.