[Webkit-unassigned] [Bug 78805] [GTK] Allow printing multiple copies in WebKit2 for printers that don't support it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 09:51:29 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78805





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-17 09:51:29 PST ---
(In reply to comment #2)
> (From update of attachment 127367 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127367&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:329
> > +                collated = 0;
> 
> This puzzled me. Why do you set collated to 0 in this case? Is it so that if there are uncollated copies left the count will start from scratch?

No, there can't be collated and uncollated at the same time, they are mutually exclusive. When collatedCopiesLeft() is 0, it's because collated == collatedCopies - 1, so we reset it to 0, so that next page is collated again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list