[Webkit-unassigned] [Bug 78872] [chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78872





--- Comment #5 from Adrienne Walker <enne at google.com>  2012-02-17 09:49:54 PST ---
(From update of attachment 127514)
View in context: https://bugs.webkit.org/attachment.cgi?id=127514&action=review

> Source/WebCore/platform/chromium/ScrollbarThemeCCScrollExample.cpp:74
> +    float barBegin = scrollbar->currentPos() / scrollbar->totalSize();
> +    float barEnd = (scrollbar->currentPos() + scrollbar->visibleSize()) / scrollbar->totalSize();

I don't think this will work without pkotwicz's change in bug 78028.  Scrollbar is an object owned and manipulated on the main thread side.  We don't want to read values from it directly, as it could be being manipulated by the other thread in ways that aren't valid for the current frame on the impl side.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1866
> +            if (ScrollbarThemeCCScroll* theme = scrollbar->theme()->toScrollbarThemeCCScroll())
> +                theme->attachToGraphicsLayer(scrollbar, m_scrollLayer.get(), m_layerForVerticalScrollbar.get());

Aren't we going to want to be able to draw any kind of scrollbar theme on the impl side? I'm not sure I follow what this class is trying to do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.