[Webkit-unassigned] [Bug 78389] wtf/ThreadingWin.cpp doesn't build for 64-bit Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 09:09:15 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78389


Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127602|                            |review?
               Flag|                            |




--- Comment #12 from Kalev Lember <kalevlember at gmail.com>  2012-02-17 09:09:14 PST ---
Created an attachment (id=127602)
 --> (https://bugs.webkit.org/attachment.cgi?id=127602&action=review)
Patch v5

Thank you for the review, Adam!

Applied all the suggested changes. The leakPtr() return value checking was only there to silence the compiler warnings, so I'm very glad there was a cleaner (or at least a more obvious) way to do it.

// Balanced by adoptPtr() in wtfThreadEntryPoint.
ThreadFunctionInvocation* leakedInvocation = invocation.leakPtr();
UNUSED_PARAM(leakedInvocation);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list