[Webkit-unassigned] [Bug 78876] Fine-grained JSC JIT code profiling at the function level

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78876


Yuqiang Xian <yuqiang.xian at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127520|0                           |1
        is obsolete|                            |
 Attachment #127585|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Yuqiang Xian <yuqiang.xian at intel.com>  2012-02-17 07:16:48 PST ---
Created an attachment (id=127585)
 --> (https://bugs.webkit.org/attachment.cgi?id=127585&action=review)
updated patch

Gavin, thanks for pointing out the problem.

Yes, as you mentioned, I think we should do the JIT symbol mapping stuffs after sampling. And I think when the profiling is ended and the profile is reported the CodeBlocks _should_ be alive. As the CodeProfiling stuff will be cleaned-up when we get out of evaluate(), while the CodeBlocks are allocated in the heap which are supposed to be reclaimed later. So this new patch is based on this assumption.

Example profiling output:

<CodeProfiling /mnt/supplement/kraken/tests/kraken-1.1/ai-astar.js:1>
Total samples: 8354
    8259: [[DFGJIT]] : search (Lines: 48-118) (8259 stack top)
      82: [[EngineCode]] (0 stack top)
          82: <unknown> (82 stack top)
      10: [[DFGJIT]] : neighbors (Lines: 125-143) (10 stack top)
       1: [[DFGJIT]] : findGraphNode (Lines: 7-12) (1 stack top)
       1: [[DFGJIT]] : init (Lines: 38-47) (1 stack top)
       1: [[BaselineOSR]] : init (Lines: 38-47) (1 stack top)
</CodeProfiling /mnt/supplement/kraken/tests/kraken-1.1/ai-astar.js:1>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.