[Webkit-unassigned] [Bug 73634] [GTK] AC - Add TextureMapperCairo implementation and widget glue

Fri Feb 17 07:11:03 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=73634

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com

--- Comment #8 from Philippe Normand <pnormand at igalia.com>  2012-02-17 07:11:03 PST ---
This patch no longer builds. I guess it's because of some recent changes in the TextureMapper:

In file included from ../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.cpp:23:0:
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.h: In static member function ‘static WTF::PassOwnPtr<WebCore::TextureMapper> WebCore::TextureMapperCairo::create()’:
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.h:75:69: error: cannot allocate an object of abstract type ‘WebCore::TextureMapperCairo’
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.h:59:7: note:   because the following virtual functions are pure within ‘WebCore::TextureMapperCairo’:
../../../Source/WebCore/platform/graphics/texmap/TextureMapper.h:109:30: note:     virtual WebCore::TextureMapper::AccelerationMode WebCore::TextureMapper::accelerationMode() const
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.cpp: In member function ‘virtual WTF::PassRefPtr<WebCore::BitmapTexture> WebCore::TextureMapperCairo::createTexture()’:
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.cpp:236:44: error: cannot allocate an object of abstract type ‘WebCore::BitmapTextureCairo’
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.h:31:7: note:   because the following virtual functions are pure within ‘WebCore::BitmapTextureCairo’:
../../../Source/WebCore/platform/graphics/texmap/TextureMapper.h:60:18: note:     virtual void WebCore::BitmapTexture::updateContents(WebCore::Image*, const WebCore::IntRect&, const WebCore::IntRect&, WebCore::BitmapTexture::PixelFormat)
../../../Source/WebCore/platform/graphics/texmap/TextureMapper.h:61:18: note:     virtual void WebCore::BitmapTexture::updateContents(const void*, const WebCore::IntRect&)
../../../Source/WebCore/platform/graphics/cairo/TextureMapperCairo.cpp:237:1: warning: control reaches end of non-void function [-Wreturn-type]
make[1]: *** [Source/WebCore/platform/graphics/cairo/libWebCoreGtk_la-TextureMapperCairo.lo] Error 1

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.