[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 05:18:58 PST 2012


--- Comment #30 from Ben Murdoch <benm at google.com>  2012-02-17 05:18:55 PST ---
(From update of attachment 127553)
View in context: https://bugs.webkit.org/attachment.cgi?id=127553&action=review

Thanks for the latest patch Jongseok! This looks closer to me to what the original reviewers were looking for. I am not a reviewer so cannot formally review the patch, but I have a few comments and will defer back to the original reviewers for their thoughts. Sam, would you mind taking another look at this?

Cheers, Ben

> Source/WebCore/platform/FileChooser.cpp:64
> +    return static_cast<MediaCaptureChooser*>(m_chooser.get());

Don't think the static_cast is needed?

> Source/WebCore/platform/FileChooser.cpp:73
> +        for (Vector<String>::const_iterator iterator = input->acceptMIMETypes().begin(); iterator != input->acceptMIMETypes().end(); ++iterator)

Could this be replaced with something like:
if (MIMETypeRegistry::isSupportCaptureType("image/*") && input->acceptMIMETypes().contains("image/*)) ?

> Source/WebCore/platform/FileChooser.h:44
> +#endif

Maybe merge these two #ifdef blocks?

> Source/WebCore/platform/FileChooser.h:51
> +    Microphone,

These should probably be in alphabetical order.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list