[Webkit-unassigned] [Bug 77933] [EFL] Use modifier keys to execute pre-rendering.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77933





--- Comment #6 from Chang Shu <cshu at webkit.org>  2012-02-17 02:24:32 PST ---
(From update of attachment 126077)
View in context: https://bugs.webkit.org/attachment.cgi?id=126077&action=review

> Tools/EWebLauncher/main.c:436
> +    if (!strcmp(ev->key, "Control_L"))
> +        modifierKey |= ECORE_EVENT_MODIFIER_CTRL;

Why isn't this a part of the if-elseif block below?
In another question, a key event usually comes in with modifier status. That is to say, when you have ev->key=="g", you check if ev->modifier==CTRL-L(note this is my fake code). Isn't it the case in EFL? Using a static modiferkey variable seems hacky.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.