[Webkit-unassigned] [Bug 75543] [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75543





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2012-02-17 01:33:57 PST ---
(From update of attachment 126740)
View in context: https://bugs.webkit.org/attachment.cgi?id=126740&action=review

LGTM! I was a bit worried by the JSValue exposure in the API but after talking with Carlos it seems we don't have much choice.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1432
> + * Finish an asynchronous operation started with webkit_web_view_can_execute_editing_command().

Hum copy/paste error? Not sure this has anything to do with webkit_web_view_can_execute_editing_command() ;)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1433
> + * The returned JSValueRef is a temporary value that should be consumed inmediately.

immediately

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.