[Webkit-unassigned] [Bug 78872] [chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78872





--- Comment #4 from Tien-Ren Chen <trchen at chromium.org>  2012-02-17 01:05:46 PST ---
(In reply to comment #2)
> (From update of attachment 127514 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127514&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:1839
> > +#if PLATFORM(CHROMIUM)
> > +            Scrollbar* scrollbar = m_renderView->frameView()->horizontalScrollbar();
> > +            if (ScrollbarThemeCCScroll* theme = scrollbar->theme()->toScrollbarThemeCCScroll())
> > +                theme->attachToGraphicsLayer(scrollbar, m_scrollLayer.get(), m_layerForHorizontalScrollbar.get());
> > +#endif
> 
> if you look a few lines below here there's a call to ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange().  I think we want to put the ScrollbarLayerChromium creation and hookup inside our implementation of that function, not in here.
> 
> I also don't think that this should have anything at all to do with the ScrollbarTheme.

Yes I agree with you. It is in the current shape only because we don't have a ScrollingCoordinatorChromium yet. :)

I talked with Alex this evening. He also gave me some good comments that the ScrollingCoordinator should take the ownership of the scrollbar PlatformLayer.

I'll take a look at ScrollingCoordinator and see how do we integrate that to our tree synchronization.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.