[Webkit-unassigned] [Bug 38995] link element for CSS stylesheet should emit load event when sheet loads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38995


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56582|0                           |1
        is obsolete|                            |
 Attachment #127527|                            |review?
               Flag|                            |




--- Comment #18 from Daniel Bates <dbates at webkit.org>  2012-02-16 22:55:18 PST ---
Created an attachment (id=127527)
 --> (https://bugs.webkit.org/attachment.cgi?id=127527&action=review)
Patch and layout tests

I ran into the same issue as Gavin Peters, <https://bugs.webkit.org/show_bug.cgi?id=51941#c45>, with regards to the need for a one-shot timer to reliably dispatch load events. As Gavin remarked, such an approach is used in ImageLoader. I spent some time trying to debug this issue, but I was unable to diagnose the cause. If I have additional time tomorrow, I'll look to further debug this issue.

For completeness, error events seemed to be reliably dispatched regardless of whether they were dispatched from a one-shot timer. I chose to dispatch them using a one-shot timer (managed by EventSender) to be consistent with the approach used in LinkLoader.cpp. Subsequent patches will look to better integrate class LinkLoader with class LoadEventSender and a define a default constructor for class EventSender so that we don't have to explicitly specify an event type.

I'm open to suggestions on this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.