[Webkit-unassigned] [Bug 78785] Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 21:20:19 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78785





--- Comment #4 from Mary Wu <mary.wu at torchmobile.com.cn>  2012-02-16 21:20:19 PST ---
(In reply to comment #3)
> (From update of attachment 127491 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127491&action=review
> 
> > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:159
> > +    : RenderTheme()
> 
> is this call needed?
> 
> > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:410
> > +    switch (part) {
> > +    case CheckboxPart:
> > +            {
> > +                FloatSize smallCorner(smallRadius, smallRadius);
> > +                Path path;
> > +                path.addRoundedRect(rect, smallCorner);
> > +                info.context->drawPath(path);
> 
> the switch body is over indented.

nice catch! Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list