[Webkit-unassigned] [Bug 63383] Don't check dangling icon database urls in release build if not pruning entries.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63383


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98597|review?                     |review-
               Flag|                            |




--- Comment #4 from Brady Eidson <beidson at apple.com>  2012-02-16 16:07:08 PST ---
(From update of attachment 98597)
This patch doesn't make things correct.  The code changed in this patch does indeed follow what the comment says.

The real fix is in the if statement:

if ((pruneIfFound || !danglersFound) && SQLiteStatement(m_syncDB, "SELECT url FROM PageURL WHERE PageURL.iconID NOT IN (SELECT iconID FROM IconInfo) LIMIT 1;").returnsAtLeastOneResult())
should become...
if (pruneIfFound && (danglersFound || SQLiteStatement(m_syncDB, "SELECT url FROM PageURL WHERE PageURL.iconID NOT IN (SELECT iconID FROM IconInfo) LIMIT 1;").returnsAtLeastOneResult()))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.