[Webkit-unassigned] [Bug 75253] [GTK] Implement zoom in/out in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75253


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120585|review?                     |review+
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2012-02-16 16:01:00 PST ---
(From update of attachment 120585)
View in context: https://bugs.webkit.org/attachment.cgi?id=120585&action=review

Looks good. This doesn't depend on the decision in bug 75249, so I'll r+

> Tools/MiniBrowser/gtk/BrowserWindow.c:186
> +    return zoomLevel <= maximumZoomLevel;

I guess this should be zoomLevel < maximumZoomLevel, otherwise you would be reporting you can zoom in while being at the maximum zoom level.

> Tools/MiniBrowser/gtk/BrowserWindow.c:192
> +    return zoomLevel >= minimumZoomLevel;

Same here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.