[Webkit-unassigned] [Bug 78834] New: Chromium Mac: mouse cursors set in CSS often don't display

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 13:16:33 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78834

           Summary: Chromium Mac: mouse cursors set in CSS often don't
                    display
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.6
            Status: NEW
          Severity: Major
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: avi at drissman.com


This is http://code.google.com/p/chromium/issues/detail?id=111027 and possibly http://code.google.com/p/chromium/issues/detail?id=114517. This continues the discussion from '027.

To repro:
- Load http://maps.google.com/ but do not mouse over the page.
- When the page is done loading, set a breakpoint on the last line of CachedImage::imageForRenderer, where Image::nullImage() is returned.
- Mouse over the page, continue over the breakpoint until it is called from EventHandler::selectCursor

Inside of EventHandler::selectCursor, it looks to see if the CSS style has a cursor set:

    if (style && style->cursors()) {
        const CursorList* cursors = style->cursors();
        for (unsigned i = 0; i < cursors->size(); ++i) {
            CachedImage* cimage = 0;
            StyleImage* image = (*cursors)[i].image();
            if (image && image->isCachedImage())
                cimage = static_cast<StyleCachedImage*>(image)->cachedImage();
            if (!cimage)
                continue;
            IntPoint hotSpot = (*cursors)[i].hotSpot();
            // Limit the size of cursors so that they cannot be used to cover UI elements in chrome.
            IntSize size = cimage->imageForRenderer(renderer)->size(); // ***1***
            if (size.width() > 128 || size.height() > 128)
                continue;
            if (!cimage->errorOccurred()) // ***2***
                return Cursor(cimage->imageForRenderer(renderer), hotSpot); // ***3***
        }
    }

In my repro case, there is one item in the |cursors| list. Indeed, the type is a CachedImage. Inside of CachedImage, errorOccurred() returns false, but there is no m_image. So Image::nullImage() is returned from CachedImage::imageForRenderer (line 1)

Its size is 0x0, so it passes the tests, and since no error occurred (line 2), a bogus cursor is created (line 3).

What is going on here? Why are the cached images not loading?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list