[Webkit-unassigned] [Bug 78315] REGRESSION(99539): Infinite repaint loop with SVGImage and deferred repaint timers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78315


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127403|review?                     |review+
               Flag|                            |




--- Comment #8 from Nikolas Zimmermann <zimmermann at kde.org>  2012-02-16 11:20:18 PST ---
(From update of attachment 127403)
View in context: https://bugs.webkit.org/attachment.cgi?id=127403&action=review

r=me, but please add null-checks first.

> Source/WebCore/svg/graphics/SVGImage.cpp:260
> +    return m_page->mainFrame()->view();

You should check for a null m_page,, as hasRelativeWidth etc. does.

> Source/WebCore/svg/graphics/SVGImage.h:57
> +    FrameView* frameView();

Should be const, no?

> Source/WebCore/svg/graphics/SVGImageCache.cpp:87
> +    if (m_svgImage->frameView()->needsLayout() && !m_redrawTimer.isActive())

This needs a null-check as well, m_page could be null, if not, you'l need assertions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.