[Webkit-unassigned] [Bug 76181] [GTK] FullScreen signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76181





--- Comment #15 from Martin Robinson <mrobinson at webkit.org>  2012-02-16 09:00:38 PST ---
(From update of attachment 125110)
View in context: https://bugs.webkit.org/attachment.cgi?id=125110&action=review

Looks good to me, but you need to find one more reviewer to approve the API.

>> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:935
>> +    if(!widgetIsOnscreenToplevelWindow(window))
> 
> Missing space before ( in if(  [whitespace/parens] [5]

Please fix this before landing.

> Source/WebKit/gtk/tests/testwebview.c:368
> +    // create and send the event

You can just omit this comment or, if not, be sure to use a capital letter and a period.

> Source/WebKit/gtk/tests/testwebview.c:476
> +    g_test_add_data_func("/webkit/webview/fullscreen", (gconstpointer)FALSE, test_webkit_web_view_fullscreen);
> +    g_test_add_data_func("/webkit/webview/fullscreen-blocked", (gconstpointer)TRUE, test_webkit_web_view_fullscreen);

You should use GINT_TO_POINTER here instead of casting yourself, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.