[Webkit-unassigned] [Bug 78822] [Texmap] Improve the way we deal with BGRA extension

Thu Feb 16 08:38:36 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=78822

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127384|review?                     |review+
               Flag|                            |

--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-02-16 08:38:36 PST ---
(From update of attachment 127384)
View in context: https://bugs.webkit.org/attachment.cgi?id=127384&action=review

r=me but please fix the minor issues

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:638
> +    return (availableExtensions.contains(extension));

why the extra ()s?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:640
> +static bool hasBgraExtension()

BGRA* this is webkit style not Qt :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.