[Webkit-unassigned] [Bug 76448] [GTK] Add WebKitPrintOperation to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76448





--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-16 08:37:37 PST ---
(In reply to comment #12)
> (From update of attachment 126944 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126944&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:86
> > +    priv->webViewDestroyedId = g_signal_connect(priv->webView, "destroy", G_CALLBACK(webViewDestroyed), printOperation);
> 
> Do you think it would be slightly cleaner to use a weak reference here? Not a big deal either way.

Transient-for is implemented this way in GtkWindow.

> > Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:248
> > +        if (gtk_widget_is_toplevel(toplevel) && GTK_IS_WINDOW(toplevel))
> > +            parent = GTK_WINDOW(toplevel);
> 
> Would it make sense to use the new helper here?

Indeed

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:665
> > +     * You can connect to this signal and return %TRUE to cancel the print operation.
> 
> Might want to add "or implement your own print dialog"

Sure!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.