[Webkit-unassigned] [Bug 78390] Web Inspector: Switch Debugger agent to TypeBuilder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78390





--- Comment #10 from Peter Rybin <prybin at chromium.org>  2012-02-14 15:41:31 PST ---
(In reply to comment #9)
> (From update of attachment 127048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127048&action=review
> 
> > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:324
> > +    using WebCore::TypeBuilder::Debugger::Location;
> 
> Why isn't this statement at the beginning of the file?
> This seems to be forbidden by style guide and you need to use a long name for return value type because of that.

Are you sure it IS forbidden?

Anyway Location clashes with WebCore::Location and it's why the previous patch didn't compile. I think this form might be optimal. Return value is OK, we have to do it in .h anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.