[Webkit-unassigned] [Bug 78529] [chromium] fast/canvas/canvas-text-alignment.html fails in Linux debug GPU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78529





--- Comment #6 from Ami Fischman <fischman at chromium.org>  2012-02-14 14:08:22 PST ---
(In reply to comment #4)
> 1.) In the test itself, call window.internals.setMockScrollbarsEnabled(true)

If I do this there is no change in the output image, and the text output complains that this method doesn't exist.

> 2.) Teach the DumpRenderTree binary that tests matching a certain pattern should default to mock scrollbars.  http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShell.cpp#L240 is where I'm doing this for tests with the string 'compositing'.  This would change both the GPU and CPU configurations, but only for Chromium.

Added there:
    if (testUrl.find("media/") != string::npos
        || testUrl.find("media\\") != string::npos) {
        printf("AMI: mock: testUrl==%s\n", testUrl.c_str());  // AMI: NFS
        m_prefs.mockScrollbarsEnabled = true;
    }
and I see the printf show up in the output, but the scrollbars are still not mocks.

> I'm somewhat partial to (2) as I think we should gradually convert all layout tests over to using mock scrollbars.  Doing that would mean you'd have to rebaseline all media tests at least once.

Is there an SOP for how to do this without accidentally making tests that are legit failures now (b/c of bugs in chromium, say) suddenly turn green?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.