[Webkit-unassigned] [Bug 78210] Add support for unsigned long[] to IDL bindings to JSC.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78210





--- Comment #3 from Kihong Kwon <kihong.kwon at samsung.com>  2012-02-16 00:16:03 PST ---
(From update of attachment 127292)
View in context: https://bugs.webkit.org/attachment.cgi?id=127292&action=review

Thank you for your comments.

>> Source/WebCore/ChangeLog:7
>> +
> 
> Please describe what this patch is doing.

OK.

>> Source/WebCore/bindings/js/JSDOMBinding.h:360
>> +            result.append(static_cast<T>(indexedValue.toNumber(exec))55);
> 
> I am afraid that this conversion rule is wrong with the Web IDL spec: http://dev.w3.org/2006/webapi/WebIDL/#es-unsigned-long
> 
> It might be difficult to make such a template<class T> for all types due to complicated conversion rules in the spec. For now, maybe we can write jsUnsignedLongArrayToVector() for unsigned long[] only.

Sure - I will change that way.

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:281
>> +    } elsif ($type eq "unsigned long[]") {
> 
> We want to avoid such hard-coding, but hard-coding might be a modest solution in this case. OK.

I think so.

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2899
>> +        return "jsNumberArrayToVector<unsigned long>(exec, $value)";
> 
> I cannot find any "jsNumberArrayToVector()" in your run-bindings-tests results...

I got it. It will be added.

>> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:45
>> +#include "JSunsigned long[].h"
> 
> This is wrong.

Yes. It will be fixed.

>> Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:55
>> +#include "unsigned long[].h"
> 
> This is wrong.

Yes. It will be fixed.

>> Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:72
>> +    putDirect(exec->globalData(), exec->propertyNames().length, jsNumber(2), ReadOnly | DontDelete | DontEnum);
> 
> This is not the change caused by your patch. Maybe you need to rebaseline run-bindings-tests results before making your patch, if the results are not correct on trunk. (Sometimes people forget to update run-bindings-tests results.)

You are right. I will remove them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.