[Webkit-unassigned] [Bug 78213] run-webkit-tests should handle empty testlist

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 22:34:09 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78213





--- Comment #9 from Csaba Osztrogonac <ossy at webkit.org>  2012-02-15 22:34:09 PST ---
(In reply to comment #8)
> Okay, I now understand the context a bit better, but if you have no tests, why invoke run-webkit-tests at all? Can't you just short-circuit things in run-selective-webkit-tests? Given that it's not clear to me that this is generally the behavior one would want, it seems like getting custom behavior is better enforced in the caller, no?

I thought over, you're absolutely right. Checking it in run-selective-webkit-tests is simpler and reasonable. We will do it.

(In reply to comment #6)
> I could be convinced that passing an empty file to --test-list should not result in running all the tests, but why would we want it to do nothing and return success instead of returning an error? (This is an honest question; maybe you have some need for this behavior)?

After rethinking this one too, I support returning an 
error code if we still pass an empty testlist to NRWT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list