[Webkit-unassigned] [Bug 78589] Move the context invalidation code out from StylePropertySet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78589





--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2012-02-15 22:11:29 PST ---
(From update of attachment 127228)
View in context: https://bugs.webkit.org/attachment.cgi?id=127228&action=review

> Source/WebCore/css/StylePropertySet.cpp:1200
> +    bool changes = m_propertySet->removeProperty(propertyID, &result);
> +    if (changes) {

It seems like we don't need this local variable. Are you adding it as a documentation?

>>> Source/WebCore/dom/StyledElement.cpp:129
>>> +        InspectorInstrumentation::didInvalidateStyleAttr(document(), this);
>> 
>> Why are we calling it here now?
> 
> The inspector used to be notified by the StylePropertySet. Since the notification code is now in the CSSOM wrapper we need to do it manually here when mutating directly.

I think you meant to have StyleAttributeMutationScope here since that's what has been removed from StylePropertySet::parseDeclaration.

> Source/WebCore/dom/StyledElement.cpp:137
> +    InspectorInstrumentation::didInvalidateStyleAttr(document(), this);

Ditto about inspector -> mutation scope. In fact, you can't define a mutation scope here. You need to define it in each one of setInlineStyleProperty and call enqueueMutationRecord when changes is true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.