[Webkit-unassigned] [Bug 78589] Move the context invalidation code out from StylePropertySet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78589





--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2012-02-15 18:39:41 PST ---
(From update of attachment 127228)
View in context: https://bugs.webkit.org/attachment.cgi?id=127228&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:390
> -            inlineStyleDecl->removeProperty(CSSPropertyFontSize);
> +            element->removeInlineStyleProperty(CSSPropertyFontSize);

Wait, this can't be right. This won't be undoable. But I guess it was always like that.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:537
> -                element->ensureInlineStyleDecl()->setProperty(CSSPropertyDisplay, CSSValueInline);
> +                element->setInlineStyleProperty(CSSPropertyDisplay, CSSValueInline);
>              if (element->renderer() && element->renderer()->style()->isFloating())
> -                element->ensureInlineStyleDecl()->setProperty(CSSPropertyFloat, CSSValueNone);
> +                element->setInlineStyleProperty(CSSPropertyFloat, CSSValueNone);

These are also undoable :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.