[Webkit-unassigned] [Bug 78213] run-webkit-tests should handle empty testlist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78213





--- Comment #8 from Dirk Pranke <dpranke at chromium.org>  2012-02-15 18:29:23 PST ---
(In reply to comment #7)
> We need this change for selective testing. (see https://bugs.webkit.org/show_bug.cgi?id=78699 for details) If a change doesn't affect any tests, run-selective-webkit-tests would call run-webkit-tests with empty testlist.
> Now if you give an empty testlist to NRWT, it runs all tests. I think it shouldn't run any test and return with success (0), because a failing return code won't be good if we want to use it on a buildbot or in an EWS.

Okay, I now understand the context a bit better, but if you have no tests, why invoke run-webkit-tests at all? Can't you just short-circuit things in run-selective-webkit-tests? Given that it's not clear to me that this is generally the behavior one would want, it seems like getting custom behavior is better enforced in the caller, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.