[Webkit-unassigned] [Bug 78751] Add support for the translate attribute in html elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78751


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127249|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2012-02-15 15:43:20 PST ---
(From update of attachment 127249)
View in context: https://bugs.webkit.org/attachment.cgi?id=127249&action=review

Is there any more to this attribute?  A link to the spec would be helpful so I can read up on it easily.  Some nits below.

> Source/WebCore/ChangeLog:8
> +        Add support for the translate attribute in html elements.
> +        https://bugs.webkit.org/show_bug.cgi?id=78751
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: fast/dom/HTMLElement/translate.html

Can you add some more information to the ChangeLog, like a link to the spec?

> Source/WebCore/html/HTMLElement.cpp:823
> +            if (mode != TranslateAttributeInherit)
> +                return mode == TranslateAttributeYes;

Should we ASSERT that the mode is either TranslateAttributeYes or TranslateAttributeNo in the body of this if?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.