[Webkit-unassigned] [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units

Wed Feb 15 14:35:33 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=27160

Joe Thomas <joethomas at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126385|0                           |1
        is obsolete|                            |
 Attachment #127238|                            |review?
               Flag|                            |

--- Comment #36 from Joe Thomas <joethomas at motorola.com>  2012-02-15 14:35:31 PST ---
Created an attachment (id=127238)
 --> (https://bugs.webkit.org/attachment.cgi?id=127238&action=review)
Patch-BasedOn-Antti's Review Comments

Patch based on Antti Koivisto's review comments

Included viewportSize as one of the parameter in the getter functions of Length structure (calcValue, calcMinValue, calcFloatValue) with a default value IntSize().

Currently, the viewportSize parameter is used only when the width and height is calculated in RenderBox. Length getters are used extensively in webCore. I think it is better to include the viewport parameter in other places on a need basis. Any thoughts on this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.