[Webkit-unassigned] [Bug 78735] New: Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78735

           Summary: Several missing/incorrect guards for LOG_DISABLED=0
                    against Release build (Mac)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.7
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: burg at cs.washington.edu


Steps to reproduce:

1. Add #define LOG_DISABLED 0 near the top of wtf/Assertions.h (this is behavior that should be supported; see the top of Assertions.h)
2. Compile on Mac for Release build
3. Build will fail when linking WebKit2


Causes:

In WebKit2/Platform/mac/Logging.mac.mm:

* the implementation of WebKit::initializeLogChannel should be guarded by #if !LOG_DISABLED, but is actually guarded by #ifndef NDEBUG. This will cause build breakage if LOG_DISABLED is manually set to false in wtf/Assertions.h, but WebKit is compiled in release mode.

In WebCore/Exports/ExportFileGenerator.cpp and WebCore.exp.in:

* the export of symbol __ZN7WebCore20LogNotYetImplementedE is similarly improperly guarded by #if !defined(NDEBUG), whereas it should be guarded by #if !LOG_DISABLED


(I don't have a working copy, so can't produce a usable patch right now. But this is a 5 minute fix.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.