[Webkit-unassigned] [Bug 78730] Initial upstreaming of EditorClientBlackBerry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 13:22:42 PST 2012


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #127217|review?                     |review-
               Flag|                            |

--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-15 13:22:42 PST ---
(From update of attachment 127217)
View in context: https://bugs.webkit.org/attachment.cgi?id=127217&action=review

Looks good, can be cleaned up a bit more.

> Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp:168
> +        return m_webPagePrivate->m_dumpRenderTree->shouldEndEditingInDOMRange(range);

We are a bit inconsistent in usage of newlines here, compare to shouldBeginEditing. We should probably choose one style within a file.

> Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp:189
> +        return m_webPagePrivate->m_dumpRenderTree->shouldChangeSelectedDOMRangeToDOMRangeAffinityStillSelecting(fromRange, toRange, static_cast<int>(affinity), stillSelecting);

I wonder if the early return is ok here but that is something to investigate in a seperate bug.

> Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h:63
> +    virtual void registerCommandForUndo(WTF::PassRefPtr<EditCommand>);

I think you can drop all WTF prefixes in the header.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list