[Webkit-unassigned] [Bug 75792] Canvas can not calculate the bounding rect big enough for stroked text.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75792





--- Comment #7 from Matthew Delaney <mdelaney at apple.com>  2012-02-15 10:24:31 PST ---
(From update of attachment 127154)
View in context: https://bugs.webkit.org/attachment.cgi?id=127154&action=review

> LayoutTests/fast/canvas/script-tests/canvas-strokePath-cap-join.js:2
> +

Looks like this test could use layoutTestController.dumpAsText(), see: http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:2163
> +    // Fast approximation of the stroke's bounding rect.

I noticed this comment was just copied over from above. Is it still true? How much faster is it than strokeBoundingRect?

> Source/WebCore/html/canvas/CanvasRenderingContext2D.h:310
> +    void inflateStrokeRect(FloatRect&) const;

Should this functionality live here? It doesn't sound all that specific to canvas to me if it's just estimating the bounding rect of a section of stroked text. Don't we have some set of "text metrics" functions elsewhere?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.