[Webkit-unassigned] [Bug 78615] Initial upstreaming for find-in-page for BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78615


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127009|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-14 12:36:19 PST ---
(From update of attachment 127009)
View in context: https://bugs.webkit.org/attachment.cgi?id=127009&action=review

Some stuff still needs to be fixed.

> Source/WebKit/ChangeLog:5
> +

Maybe add an explanation why this change is made.

> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.h:41
> +    bool findNextString(const WTF::String& text, bool forward);

I dont think you need the WTF:: prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.