[Webkit-unassigned] [Bug 78617] MathML internals - embellished operators, getBase() accessor functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78617





--- Comment #2 from Eric Seidel <eric at webkit.org>  2012-02-14 11:12:40 PST ---
(From update of attachment 126997)
View in context: https://bugs.webkit.org/attachment.cgi?id=126997&action=review

> Source/WebCore/rendering/mathml/RenderMathMLBlock.h:54
> +    virtual const RenderMathMLOperator* unembellishedOperator() const { return 0; }

I don't think a const pointer will help you much here.  Since you won't be able to retain it...  For RefCounted objects (like Node) we normally don't bother with const much.

> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:57
> +RenderBoxModelObject* RenderMathMLSubSup::getBase() const

Normaly we don't use "get" in function names.  Since base() here would convey the same meaning.

It's unclear to me what "base" is here?  Also, it looks like you used it irght, but just to be clear, RenderBoxModelObject is the base class for all CSS-box-model renderers, this is in contrast to SVG-model renderers (which although uses CSS, does not participate in the CSS box model), which use RenderSVGModelObject.  Sometimes folks want RenderObject (to mean any kind of renderer) and sometimes they want RenderBoxModelObject (to mean only CSS-box-model renderers).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.