[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77509





--- Comment #30 from Raymond Toy <rtoy at chromium.org>  2012-02-14 09:36:05 PST ---
(In reply to comment #29)
> (In reply to comment #28)
> > (From update of attachment 126449 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=126449&action=review
> > 
> > >> LayoutTests/webaudio/resources/biquad-testing.js:73
> > >> +        a2 = 0;
> > > 
> > > nit: Can you explain why this is needed now when it wasn't needed without IPP?  When I run this with freq = 0 (and q = 1 and gain = 1) I get b0=b1=b2=0 and a1=-2 and a2=1.  Is it because there's a pole at 1?
> > 
> > I found you set b0=b1=b2=a1=a2=0 in setLowpassparams() in Biquad.cpp, and did not in the test script, I`ve thought they should be the same. Any reason to treat freq==0 condition differently?
> > 
> Ray, there is nothing special for IPP. So I won`t change the code here, if it should be different for condition freq=0.

Ok.  I can't remember why I did that in Biquad.cpp, but in the test, I wanted to have as few special cases as possible there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.