[Webkit-unassigned] [Bug 78515] DFG should be able to emit code on control flow edges

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78515


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126816|review?                     |review+
               Flag|                            |




--- Comment #4 from Gavin Barraclough <barraclough at apple.com>  2012-02-13 15:54:24 PST ---
(From update of attachment 126816)
View in context: https://bugs.webkit.org/attachment.cgi?id=126816&action=review

> Source/JavaScriptCore/assembler/MacroAssembler.h:78
> +    static DoubleCondition invert(DoubleCondition cond)

At some point we should probably make double condition a common type for all assemblers (independent of machine implementation), with a guarantee that we can just invert by flipping a bit, and sue a table to map from the abstract type to a machine type.  Ditto for the integer conditions.  This looks fine for now though.

> Source/JavaScriptCore/assembler/MacroAssembler.h:110
> +    static bool isInvertible(ResultCondition cond)

Presumably we could do away with this by introducing NoOverflow/NotSigned types? Probably worth doing at some point, though not urgent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.