[Webkit-unassigned] [Bug 78435] UString.h will crash if is8bit is checked and UString::isNull() == true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78435





--- Comment #13 from Geoffrey Garen <ggaren at apple.com>  2012-02-13 11:23:30 PST ---
> In bug 77593, we didn't add a null check because it's not there by design, for better performance. Sadly, this discussion was not captured in the bug, it was on IRC.

I wasn't privy to that discussion, but considering performance, I still think the null check is the right move.

All C++ code that checks is8Bit() goes on to dereference the string, which checks for NULL. I'd expect the standard control-flow analysis in any optimizing compiler to merge the two NULL checks, resulting in no runtime performance cost.

> If we decide to make this change after all, the fix for bug 77593 should likely be reverted, and a similar cheek in ScriptController should be removed, too.

Sounds good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.