[Webkit-unassigned] [Bug 78495] Flakiness dashboard should show Linux ChromiumOS test results.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78495





--- Comment #4 from Robert Flack <flackr at chromium.org>  2012-02-13 10:44:15 PST ---
(In reply to comment #2)
> (From update of attachment 126767 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126767&action=review
> 
> Just a couple style nits.
> 
> This patch needs a ChangeLog file entry before it can be committed. I recommend uploading the patch using "Tools/Scripts/webkit-patch upload 78495 ".  That will automatically generate the ChangeLog entry for you and upload it here. Notably it will also set the r? flag for you which marks this as a patch needing review.
> 
> > Tools/TestResultServer/static-dashboards/builders.js:44
> > +CHROMIUM_CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/builders/');
> 
> Nit: The Chromium is clear from ChromiumOS, can we call these CHROMIUMOS_BUILDER_MASTER and 'ChromiumOS'?
> 

I changed the variable to CHROMIUMOS_BUILDER_MASTER. As for the master name, the master on test-results.appspot.com is called ChromiumChromiumOS, if I change this here I would have to map it back to ChromiumChromiumOS when building the request URL for test results. I think to change the actual master name would require many changes elsewhere.

> > Tools/TestResultServer/static-dashboards/dashboard_base.js:181
> > +            function() { return value in LAYOUT_TESTS_BUILDER_GROUPS ||
> > +                                value in CHROMIUM_GTESTS_BUILDER_GROUPS; });
> 
> I'd either make this a single-line or break it up into normal function format like so:
> function() {
>     return foo ||
>         bar;
> }

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.