[Webkit-unassigned] [Bug 78495] Flakiness dashboard should show Linux ChromiumOS test results.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78495





--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2012-02-13 09:58:48 PST ---
(From update of attachment 126767)
View in context: https://bugs.webkit.org/attachment.cgi?id=126767&action=review

Just a couple style nits.

This patch needs a ChangeLog file entry before it can be committed. I recommend uploading the patch using "Tools/Scripts/webkit-patch upload 78495 ".  That will automatically generate the ChangeLog entry for you and upload it here. Notably it will also set the r? flag for you which marks this as a patch needing review.

> Tools/TestResultServer/static-dashboards/builders.js:44
> +CHROMIUM_CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/builders/');

Nit: The Chromium is clear from ChromiumOS, can we call these CHROMIUMOS_BUILDER_MASTER and 'ChromiumOS'?

> Tools/TestResultServer/static-dashboards/dashboard_base.js:181
> +            function() { return value in LAYOUT_TESTS_BUILDER_GROUPS ||
> +                                value in CHROMIUM_GTESTS_BUILDER_GROUPS; });

I'd either make this a single-line or break it up into normal function format like so:
function() {
    return foo ||
        bar;
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.