[Webkit-unassigned] [Bug 78389] wtf/ThreadingWin.cpp doesn't build for 64-bit Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78389





--- Comment #4 from Adam Roben (:aroben) <aroben at apple.com>  2012-02-13 07:45:25 PST ---
(From update of attachment 126582)
View in context: https://bugs.webkit.org/attachment.cgi?id=126582&action=review

>> Source/JavaScriptCore/wtf/ThreadingWin.cpp:223
>> +    return 0;
> 
> The main issue I see is that this breaks the waitForThreadCompletion API, which "promises" you a void* returned by the thread function, which will work on all platforms except on Windows (after your change).
> 
> I don't see anyone in WebKit actually relying on thread result, so perhaps the API should be changed at the same time as this fix, to ensure that nobody accidentally introduces code that relies on it and finds it working on their Mac/Linux but see it silently break on Windows.

I'd actually suggest changing the API first, then making any changes necessary for 64-bit on Windows separately. You have to be a little careful when changing the API, though, because Safari uses some of these WTF thread functions (see bug 25348 comment 12).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.