[Webkit-unassigned] [Bug 78435] UString.h will crash if is8bit is checked and UString::isNull() == true

Mon Feb 13 07:18:14 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=78435

--- Comment #12 from Adam Treat <atreat at rim.com>  2012-02-13 07:18:14 PST ---
(In reply to comment #11)
> In bug 77593, we didn't add a null check because it's not there by design, for better performance. Sadly, this discussion was not captured in the bug, it was on IRC.
> 
> If we decide to make this change after all, the fix for bug 77593 should likely be reverted, and a similar cheek in ScriptController should be removed, too.

Interesting.  Well, I can say that my patch doesn't fix the crash as there are other places in the code that do a similar null-pointer de-reference if you get further than just returning JSUndefined where Benjamin did.  Let me know if I should continue with this or if you really intend to let  UString::is8Bit and/or WTF::String::is8Bit have potential null pointer derefs like this.  I think at the least that an ASSERT should be added which won't impact release build performance since it is defined out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.