[Webkit-unassigned] [Bug 78389] wtf/ThreadingWin.cpp doesn't build for 64-bit Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78389





--- Comment #3 from Kalev Lember <kalevlember at gmail.com>  2012-02-13 06:25:01 PST ---
(In reply to comment #2)
> The main issue I see is that this breaks the waitForThreadCompletion API, which "promises" you a void* returned by the thread function, which will work on all platforms except on Windows (after your change).

I believe my patch actually doesn't change the status quo: waitForThreadCompletion implementation in ThreadingWin.cpp as it is completely ignores the 'void** result' parameter. So with my change, it doesn't get any worse or any better -- it still won't return anything to the caller through '**result'.


Having said that, I agree that current situation where ThreadFunction returns a void* and then the thread's return value is completely ignored in waitForThreadCompletion on Windows isn't good. Should I try to come up with a patch to change the signature of ThreadFunction to return unsigned? It would be pretty invasive, touching a lot of files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.