[Webkit-unassigned] [Bug 78091] [EFL][DRT] Implement zoomPage{In, Out} and textZoom{In, Out} events.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 12 17:37:35 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78091





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-02-12 17:37:34 PST ---
(In reply to comment #4)
> (From update of attachment 126248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review
> 
> I recommend to split the patch into code-only part and rebaselining until efl DRT is available on the bot.
> Rebaselining is kinda semi automatic stuff but the code change is not.

I will guide to split between code-only part and test codes.

> > Tools/DumpRenderTree/efl/EventSender.cpp:454
> > +static void textZoom(bool zoomIn)
> 
> Enum would be better in these case.
> 
> > Tools/DumpRenderTree/efl/EventSender.cpp:469
> > +static void pageZoom(bool zoomIn)
> 
> Enum would be better in these case.

Kangil, could you change zoomIn parameter with enum type?

Moritta,

I'm build efl test bot on Bug 77518 and Bug78348. I think you're able to enough to review Bug 78348. Could you do that ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list