[Webkit-unassigned] [Bug 78091] [EFL][DRT] Implement zoomPage{In, Out} and textZoom{In, Out} events.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 12 17:04:13 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=78091
MORITA Hajime <morrita at google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #126248|review? |review+
Flag| |
--- Comment #4 from MORITA Hajime <morrita at google.com> 2012-02-12 17:04:13 PST ---
(From update of attachment 126248)
View in context: https://bugs.webkit.org/attachment.cgi?id=126248&action=review
I recommend to split the patch into code-only part and rebaselining until efl DRT is available on the bot.
Rebaselining is kinda semi automatic stuff but the code change is not.
> Tools/DumpRenderTree/efl/EventSender.cpp:454
> +static void textZoom(bool zoomIn)
Enum would be better in these case.
> Tools/DumpRenderTree/efl/EventSender.cpp:469
> +static void pageZoom(bool zoomIn)
Enum would be better in these case.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list