[Webkit-unassigned] [Bug 78435] UString.h will crash if is8bit is checked and UString::isNull() == true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78435





--- Comment #9 from Adam Treat <atreat at rim.com>  2012-02-12 14:25:56 PST ---
(In reply to comment #8)
> Adam,
> 
> I think Benjamin is suggesting -- and I agree -- that you should fix WTFString as well, so that UString and WTFString remain consistent. We need this consistency so we can eliminate UString over time, in favor of WTFString.
> 
> WTFString contains this:
> 
>     bool is8Bit() const { return m_impl->is8Bit(); }
> 
> You should fix it.

Maybe I'(In reply to comment #8)
> Adam,
> 
> I think Benjamin is suggesting -- and I agree -- that you should fix WTFString as well, so that UString and WTFString remain consistent. We need this consistency so we can eliminate UString over time, in favor of WTFString.
> 
> WTFString contains this:
> 
>     bool is8Bit() const { return m_impl->is8Bit(); }
> 
> You should fix it.

Ok, I see the disconnect.  My tree (RIM's internal tree) is older and I don't have the change that added 'WTF::String::is8Bit()' yet so I didn't understand what Benjamin meant by it is inconsistent with WTF::String.  I will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.