[Webkit-unassigned] [Bug 78435] UString.h will crash if is8bit is checked and UString::isNull() == true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78435





--- Comment #5 from Adam Treat <atreat at rim.com>  2012-02-12 13:21:45 PST ---
(In reply to comment #3)
> (From update of attachment 126679 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126679&action=review
> 
> > Source/JavaScriptCore/runtime/UString.h:103
> > -    bool is8Bit() const { return m_impl->is8Bit(); }
> > +    bool is8Bit() const
> > +    {
> > +        return m_impl && m_impl->is8Bit();
> > +    }
> 
> You are making UString inconsistent with WTFString. I think this is a really bad idea.
> 
> This was made by design.

How is this inconsistent exactly?? WTFString does not have an 'is8Bit' method, but StringImpl does... But I still don't get how this is inconsistent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.