[Webkit-unassigned] [Bug 78435] UString.h will crash if is8bit is checked and UString::isNull() == true

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 12 12:39:22 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78435





--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2012-02-12 12:39:22 PST ---
(From update of attachment 126679)
View in context: https://bugs.webkit.org/attachment.cgi?id=126679&action=review

> Source/JavaScriptCore/runtime/UString.h:103
> -    bool is8Bit() const { return m_impl->is8Bit(); }
> +    bool is8Bit() const
> +    {
> +        return m_impl && m_impl->is8Bit();
> +    }

You are making UString inconsistent with WTFString. I think this is a really bad idea.

This was made by design.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list